Skip to content

Conversation

artembilan
Copy link
Member

The reason for this change is that content in the target DB might not always be a byte array. And we already have an outstanding work for providing JSON format for a message content.

Related to: #9312

This is mostly an automatic find-n-replace change, therefore not too much to review.

The reason for this change is that content in the target DB might not always be a byte array.
And we already have an outstanding work for providing JSON format for a message content.

Related to: spring-projects#9312
@artembilan
Copy link
Member Author

After merging this I also will add a Migration Guide note: https://github.com/spring-projects/spring-integration/wiki/Spring-Integration-6.x-to-7.0-Migration-Guide

Copy link
Contributor

@cppwfs cppwfs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a quick question.

This does simplify things a quite a bit!


The message stores now use a `MESSAGE_CONTENT` column name for serialized messages instead of `MESSAGE_BYTES` since the content might not always be stored as a byte array.
All the out-of-the-box SQL schemas have beed changed, too, to rely on the `MESSAGE_CONTENT` name for the respective column in the `INT_MESSAGE` and `INT_CHANNEL_MESSAGE` tables.
See xref:jdbc/message-store.adoc[] for more information.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to mention that they need to update existing schemas?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right. That is what a Migration Guide for.
I don't think the scope of the doc for specific version is a responsibility of such a guidance.

Copy link
Contributor

@cppwfs cppwfs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cppwfs cppwfs merged commit 21b63d1 into spring-projects:main Oct 21, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants