spring-projectsGH-3169: Fix DefaultSessionFactoryLocator addSessionFactory key's type from String to Objec #3171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artembilan
requested changes
Feb 6, 2020
...n/java/org/springframework/integration/file/remote/session/DefaultSessionFactoryLocator.java
Show resolved
Hide resolved
kezhevatov
force-pushed
the
GH-3169
branch
2 times, most recently
from
2bdca46 to
0d0c0be
Compare
artembilan
requested changes
Feb 6, 2020
| */ | ||
| @Deprecated | ||
| public void addSessionFactory(String key, SessionFactory<F> factory) { | ||
| this.factories.put(key, factory); |
There was a problem hiding this comment.
I have an opinion that deprecated API should call a new one for better coverage.
This way when we need to make a change in the target logic, a deprecated API won't be affected because it is meant to be for removal eventually anyway. 😄
There was a problem hiding this comment.
Yep, it make sense. Done
…ctory key's type from String to Object All other DefaultSessionFactoryLocator contracts are based on the Object, so this addSessionFactory has to be on Object as well.
artembilan
approved these changes
Feb 7, 2020
|
Merged as edf84a3 and cherry-picked to thank you for the contribution; looking forward for more! For the future, please, consider to test the project against your changes: you have missed to fix a deprecated method usage in the Plus it would be great to make a good commit message (not a PR description, but commit): https://chris.beams.io/posts/git-commit/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GH-3169: Fix DefaultSessionFactoryLocator addSessionFactory key's type from String to Object
All other DefaultSessionFactoryLocator contracts are based on the Object, so this addSessionFactory has to be on Object as well.