GH-2638: Add Dynamic Micrometer Tags #2648
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves spring-projects#2638 **cherry-pick to 2.9.x** TODO: Support for Observations when `observationEnabled` (3.0.x only).
artembilan
requested changes
Mar 30, 2023
artembilan
requested changes
Mar 30, 2023
Co-authored-by: Artem Bilan <abilan@vmware.com>
artembilan
approved these changes
Mar 30, 2023
Member
artembilan
left a comment
artembilan
left a comment
There was a problem hiding this comment.
LGTM and merging.
I guess an Observability part will be addressed in a separate PR.
Or we already have something in the #2609 on the matter...
Contributor
Author
|
Yes; new PR coming - this is orthogonal to that other PR. |
garyrussell
added a commit
to garyrussell/spring-kafka
that referenced
this pull request
Mar 30, 2023
garyrussell
added a commit
to garyrussell/spring-kafka
that referenced
this pull request
Mar 30, 2023
Member
|
Back-ported as ad09ce3 after fixing conflicts. |
artembilan
pushed a commit
that referenced
this pull request
Mar 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2638
cherry-pick to 2.9.x
TODO: Support for Observations when
observationEnabled(3.0.x only).