GH-2817: KafkaTemplate: No double error timers #2823
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes spring-projects#2817 An observation in `KafkaTemplate` can be marked with error from a `Callback`. Then `Future` is evaluated and its exception is thrown back to the `observeSend()`. Here this exception is caught and reported to the observation again. This creates a second timer in the Micrometer, but with different error tag * Check for error presence in the `observeSend()` `catch` block and skip second report **Cherry-pick to `3.0.x`**
garyrussell
approved these changes
Sep 25, 2023
garyrussell
pushed a commit
that referenced
this pull request
Sep 25, 2023
* GH-2817: KafkaTemplate: No double error timers Fixes #2817 An observation in `KafkaTemplate` can be marked with error from a `Callback`. Then `Future` is evaluated and its exception is thrown back to the `observeSend()`. Here this exception is caught and reported to the observation again. This creates a second timer in the Micrometer, but with different error tag * Check for error presence in the `observeSend()` `catch` block and skip second report **Cherry-pick to `3.0.x`** * * Fix import order for Checkstyle rule
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2817
An observation in
KafkaTemplatecan be marked with error from aCallback. ThenFutureis evaluated and its exception is thrown back to theobserveSend(). Here this exception is caught and reported to the observation again. This creates a second timer in the Micrometer, but with different error tagobserveSend()catchblock and skip second reportCherry-pick to
3.0.x