GH-3319: Fix NPE in the KafkaListenerEndpointRegistry
#3320
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `KafkaListenerEndpointRegistry.getUnregisteredListenerContainer()` returns `null` when container is already present in the internal `unregisteredContainers` cache * Fix `KafkaListenerEndpointRegistry.getUnregisteredListenerContainer()` to return a container instance from the `unregisteredContainers` cache **Auto-cherry-pick to `3.2.x` & `3.1.x`**
Contributor
|
Do you think we need to update the Javadoc on ListenerContainerRegistry since we are not returning |
Member
Author
|
It still will be null if there is no such a bean. |
spring-builds
pushed a commit
that referenced
this pull request
Jun 20, 2024
The `KafkaListenerEndpointRegistry.getUnregisteredListenerContainer()` returns `null` when container is already present in the internal `unregisteredContainers` cache * Fix `KafkaListenerEndpointRegistry.getUnregisteredListenerContainer()` to return a container instance from the `unregisteredContainers` cache (cherry picked from commit 8096c9d)
sobychacko
pushed a commit
that referenced
this pull request
Jun 20, 2024
Fixes: #3319 The `KafkaListenerEndpointRegistry.getUnregisteredListenerContainer()` returns `null` when container is already present in the internal `unregisteredContainers` cache * Fix `KafkaListenerEndpointRegistry.getUnregisteredListenerContainer()` to return a container instance from the `unregisteredContainers` cache (cherry picked from commit 8096c9d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
KafkaListenerEndpointRegistry.getUnregisteredListenerContainer()returnsnullwhen container is already present in the internalunregisteredContainerscacheKafkaListenerEndpointRegistry.getUnregisteredListenerContainer()to return a container instance from theunregisteredContainerscacheAuto-cherry-pick to
3.2.x&3.1.x