UriModifyingContentModifier.modifyContent decodes with the request charset but re-encodes with the platform default#1043
Merged
wilkinsona merged 1 commit intospring-projects:3.0.xfrom May 7, 2026
Conversation
wilkinsona
added
type: bug
See spring-projectsgh-1043 Signed-off-by: config25 <yhkim052556@naver.com>
wilkinsona
force-pushed
the
fix/uri-modifier-charset-encoding
branch
from
e7f0e1c to
0a449a9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UriModifyingContentModifier.modifyContent() decodes the request/response
body using the charset from the Content-Type header, but re-encodes with
String.getBytes() (no charset argument), which falls back to the JVM
default. When these differ, non-ASCII characters get corrupted.
Use the same charset for both decoding and encoding, falling back to
Charset.defaultCharset() when no charset is declared.
Fixes gh-1039
Supersedes #1041 (which became un-reopenable after force-push during merge processing).