HaveIBeenPwnedRestApiPasswordChecker (blocking) catches RestClientException on failure, which covers both HTTP error responses and lower-level I/O errors such as connection timeouts and DNS failures.
The reactive counterpart, HaveIBeenPwnedRestApiReactivePasswordChecker, uses onErrorResume(WebClientResponseException.class, ...). WebClientResponseException only covers HTTP error responses (4xx/5xx).
The semantic equivalent of RestClientException in the reactive stack is WebClientException. It seems more reasonable for the reactive one to use onErrorResume(WebClientException.class, ...) to align with the blocking implementation.
HaveIBeenPwnedRestApiPasswordChecker(blocking) catchesRestClientExceptionon failure, which covers both HTTP error responses and lower-level I/O errors such as connection timeouts and DNS failures.The reactive counterpart,
HaveIBeenPwnedRestApiReactivePasswordChecker, usesonErrorResume(WebClientResponseException.class, ...).WebClientResponseExceptiononly covers HTTP error responses (4xx/5xx).The semantic equivalent of
RestClientExceptionin the reactive stack isWebClientException. It seems more reasonable for the reactive one to useonErrorResume(WebClientException.class, ...)to align with the blocking implementation.