Fix Formatting in mfa.adoc#18134
Conversation
spring-projects-issues
added
the
status: waiting-for-triage
rwinch
left a comment
rwinch
left a comment
There was a problem hiding this comment.
Thank you for the PR @ngocnhan-tran1996
The Spring Security team prefers using the xref macro (e.g. xref:./page.adoc#id[Text]) to the shorthand xref notation (e.g. <<id>>) because the shorthand xref has limitations (e.g. it does not work with the assembler extension).
Is there a reason for changing to the shorthand xref notation in mfa.adoc? Unless there is a good reason (that the team approves of), I think that the shorthand xref changes should be removed.
rwinch
added
status: waiting-for-feedback
rwinch
added
in: docs
ngocnhan-tran1996
force-pushed
the
update-mfa-document
branch
2 times, most recently
from
fef52e4 to
deaad6e
Compare
|
Thanks for the information. I've switched to using |
spring-projects-issues
added
status: feedback-provided
Signed-off-by: Tran Ngoc Nhan <ngocnhan.tran1996@gmail.com>
Signed-off-by: Tran Ngoc Nhan <ngocnhan.tran1996@gmail.com>
Incldue the required resource id and required # of the fragment. See - https://docs.antora.org/antora/latest/page/xref/#xref-macro - https://docs.antora.org/antora/latest/page/resource-id-coordinates/#id-resource
rwinch
force-pushed
the
update-mfa-document
branch
from
deaad6e to
e2bac4e
Compare
|
@ngocnhan-tran1996 Once again thank you for your submission. I rebased and restored the xref macro resource id. In the future, it would be helpful for you to submit changes that are fixing things that are obviously broken separately from things that you believe to be clean up (e.g. This will be merged once the build passes. Thanks again! |
3 participants
No description provided.