JwtAuthenticationProvider authenticate nullability fix#18305
Open
alfonsoristorato wants to merge 2 commits intospring-projects:mainfrom
Open
JwtAuthenticationProvider authenticate nullability fix#18305alfonsoristorato wants to merge 2 commits intospring-projects:mainfrom
JwtAuthenticationProvider authenticate nullability fix#18305alfonsoristorato wants to merge 2 commits intospring-projects:mainfrom
Conversation
…tication Signed-off-by: alfonsoristorato <alfonsoristorato@gmail.com>
spring-projects-issues
added
the
status: waiting-for-triage
Signed-off-by: alfonsoristorato <alfonsoristorato@gmail.com>
Author
|
@rwinch I see you are very active on PRs, sorry to tag :), but it would be good to have some feedback on this or docs update if this nullability is indeed the way forward |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressing issue I created #18229. Not sure if this was ever intended to be nullable, but as we throw when token is null it makes sense to me to add
@NotNullNo tests added as this is already covered in
spring-security/oauth2/oauth2-resource-server/src/test/java/org/springframework/security/oauth2/server/resource/authentication/JwtAuthenticationProviderTests.java
Line 157 in f6cb0bd