Deprecate BCrypt.gensalt() without SecureRandom parameter #18560
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
Creating a new SecureRandom instance on every call causes unnecessary performance overhead. This change: - Deprecates BCrypt.gensalt(String, int) method - Modifies BCryptPasswordEncoder constructors to create and reuse SecureRandom instances - Maintains backward compatibility All existing tests pass. Closes spring-projectsgh-17824 Signed-off-by: Yerin Lee <rt8632@naver.com>
- Deprecates BCrypt.gensalt(int) method Closes spring-projectsgh-17824 Signed-off-by: Yerin Lee <rt8632@naver.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecate
BCrypt.gensalt(String, int)and modifyBCryptPasswordEncoderconstructors to create and reuseSecureRandominstances.Closes gh-17824