Always fallback to AccessDeniedHandlerImpl for unmatched requests#18889
Closed
answndud wants to merge 1 commit intospring-projects:mainfrom
Closed
Always fallback to AccessDeniedHandlerImpl for unmatched requests#18889answndud wants to merge 1 commit intospring-projects:mainfrom
answndud wants to merge 1 commit intospring-projects:mainfrom
Conversation
Signed-off-by: MJY <jmoon0227@gmail.com>
spring-projects-issues
added
the
status: waiting-for-triage
Author
|
Closing this for now. I opened it too early before the team had decided whether this behavior should change, and I do not want to create extra noise while that decision is still open. If maintainers decide this direction is desirable later, I can revisit it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes gh-18871
ExceptionHandlingConfigurer#createDefaultAccessDeniedHandlercurrently returns the configured handler directly when only onedefaultAccessDeniedHandlerFormapping is registered. In that case, unmatched requests do not fall back toAccessDeniedHandlerImpl.This change always uses
RequestMatcherDelegatingAccessDeniedHandlerwhen default denied handler mappings are present so that unmatched requests consistently fall back toAccessDeniedHandlerImpl.It also updates the regression test for the single-matcher case to verify that only matching requests use the custom handler and non-matching requests return
403 Forbidden.Testing:
export JAVA_HOME=/opt/homebrew/opt/openjdk/libexec/openjdk.jdk/Contents/Home; export PATH="$JAVA_HOME/bin:$PATH"; export NPM_CONFIG_WORKSPACES=false; ./gradlew :spring-security-config:test --tests org.springframework.security.config.annotation.web.configurers.ExceptionHandlingConfigurerAccessDeniedHandlerTests