Add allowIfSubType for URL and Instant in OAuth2ClientJacksonModule#19243
Open
qwerty7878 wants to merge 1 commit into
Open
Add allowIfSubType for URL and Instant in OAuth2ClientJacksonModule#19243qwerty7878 wants to merge 1 commit into
qwerty7878 wants to merge 1 commit into
Conversation
Signed-off-by: hyeonjune <annhj980@naver.com>
809a078 to
fd660f1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes gh-19241
Problem
OAuth2ClientJacksonModulewas missingallowIfSubTypeentries forjava.net.URLandjava.time.Instant, causing aSerializationExceptionwhen deserializing OAuth2 authentication tokens stored in Redis session. The error occurs becauseOidcIdTokenclaims containissas aURLandiat/expasInstant, which thePolymorphicTypeValidatordenied.Fix
Added
allowIfSubType(URL.class)andallowIfSubType(Instant.class)toconfigurePolymorphicTypeValidatorinOAuth2ClientJacksonModule.Tests
deserializeWhenClaimsContainUrlAndInstantThenDeserializes— verifies thatOAuth2AuthenticationTokencontainingURLandInstantclaim types can be serialized and deserialized successfully