Use SCOPE instead of CLIENT_ID for access_denied in device authorization consent#19258
Open
therepanic wants to merge 1 commit into
Open
Use SCOPE instead of CLIENT_ID for access_denied in device authorization consent#19258therepanic wants to merge 1 commit into
SCOPE instead of CLIENT_ID for access_denied in device authorization consent#19258therepanic wants to merge 1 commit into
Conversation
…ion consent The current behavior is misleading (for example, as in spring-projectsgh-19238). It was likely implemented by accident as a result of copy-pasting, since the `client_id` check was performed earlier in the `OAuth2DeviceAuthorizationConsentAuthenticationProvider#authenticate` method, and the current behavior has nothing to do with `client_id`, but rather with checking authorities, i.e., scope. Ref: spring-projectsgh-19238 Ref: spring-projectsgh-19256 Signed-off-by: Andrey Litvitski <andrey1010102008@gmail.com>
2 tasks
spring-projects-issues
added
the
status: waiting-for-triage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current behavior is misleading (for example, as in gh-19238). It was likely implemented by accident as a result of copy-pasting, since the
client_idcheck was performed earlier in theOAuth2DeviceAuthorizationConsentAuthenticationProvider#authenticatemethod, and the current behavior has nothing to do withclient_id, but rather with checking authorities, i.e., scope.Ref: gh-19238
Ref: gh-19256