Pass Java installation and info from Java LS per project #1700
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Makes a lot of sense to me, looks great. The only thing that comes to my mind is whether to call it |
Signed-off-by: BoykoAlex <alex.boyko@broadcom.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Java version is passed from Java LS to Boot LS. Thought it might be a good opportunity to pass just
VMobject rather than a lonely java version string and include that project's java home/installation folder along with it in theVMobject.There is a utility added to
JavaUtilsfindJavaExecutable(File vmInstallationLocation)that is taken fromStandardVMTypein JDT launching.There is a
JavaUtils.javaHomeFromLibJar(Path libJar)which we could use to find java home for a project from the jre lib jar... that would be a less disturbing change.Felt like passing the java home (or a java executable) from the java ls might be more robust... At the same time the JRE/JDK file system layout hasn't changed for as far as i can remember...