Skip to content

Add reactive support for transit operations #778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Add reactive support for transit operations #778

wants to merge 2 commits into from

Conversation

@james-luke-airwallex
Copy link
Contributor

@james-luke-airwallex james-luke-airwallex commented Apr 11, 2023

@mp911de mp911de added the type: enhancement A general enhancement label Apr 11, 2023
@mp911de
Copy link
Member

mp911de commented Apr 11, 2023

Thanks for your contribution. Looks decent from a cursory look. Let me have a deeper look in the next few days.

mp911de pushed a commit that referenced this pull request Apr 19, 2023
@james-luke-airwallex @mp911de
Add reactive support for transit operations.
0fe33b7 
Closes gh-620
Original pull request: gh-778
mp911de added a commit that referenced this pull request Apr 19, 2023
@mp911de
Polishing.
42cdfaa 
Reformat code. Rollback Jackson customizations on request objects in favor of explicit request body creaction.

Reduce method visibility to avoid unintended exposure.

See gh-620
Original pull request: gh-778
@mp911de mp911de added this to the 3.1.0-M1 milestone Apr 19, 2023
@mp911de
Copy link
Member

mp911de commented Apr 19, 2023

Thank you for your contribution. That's merged and polished now. I removed the Jackson customizations in favor of explicit request body conversion that was already in place in the imperative variant.

@mp911de mp911de closed this Apr 19, 2023
@james-luke-airwallex
Copy link
Contributor Author

james-luke-airwallex commented Apr 19, 2023

Cheers for that, I originally wrote the Jackson customization over a year ago when I first worked on the code, couldn't even remember why I added it in the first place

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

type: enhancement A general enhancement

Projects

None yet

Milestone

3.1.0-M1

Development

Successfully merging this pull request may close these issues.

Reactive support for transit operations

2 participants

@james-luke-airwallex @mp911de