Skip to content

Conversation

@wilkinsona
Copy link
Member

This change will need to be updated if #18 is merged, but I wanted to open a PR so that I don't forget about it

@garyrussell
Copy link

@wilkinsona Please also note we have an open PR to update to smack 4.0 when it is released.

We haven't decided whether this will go in a point release or wait for 4.1 (but the submitter is complaining that SI is using a "very old" smack).

@wilkinsona
Copy link
Member Author

Thanks, Gary.

It's interesting that 3.2.1 is described as "very old": it's the most recent release that's published to Maven Central so it's the latest and greatest as far as I'm concerned.

@artembilan
Copy link
Member

Guys, @Flowdalic is the Smack commiter and I'm sure he can answer for all our questions.
Anyway the latest version is 3.4.1: https://igniterealtime.org/downloads/index.jsp

@wilkinsona
Copy link
Member Author

Unfortunately, 3.4.1 is of no use to us as it's not published to Maven Central

@Flowdalic, what are you plans for the release of 4.0.0? We're looking to wrap up a number of releases in the next week or so. Is there any chance of 4.0.0 being final in that timeframe?

@Flowdalic
Copy link
Contributor

While preparing the commit to update Smack in spring-integration (INT-3383) I discovered that Smack is also used in spring-ws. And since there seems to be a dependency between spring-ws and spring-integration, both projects must always have a compatible API version of Smack. I've prepared a commit updating spring-ws to Smack 4 at https://github.com/flowdalic/spring-ws/tree/smack4, but decided to not send a pull request until Smack 4.0.0-rc2 is released.

The only thing that's blocking a 4.0.0-rc2 release are some OSGi issues regarding Smack. If everything goes well, I'd expect those to be fixed in the next few days and the release by the end of the week. It's up to you to decide if you would go with a -rc2. My impression is that it's pretty stable, although a lot has of code has changed, but we got no complaints from Smack 4 testers (besides the OSGi issues).

@wilkinsona
Copy link
Member Author

I'd like to keep this PR for aligning Spring WS with Spring Integration's current Smack dependency, i.e. 3.2.1. We can consider an upgrade to 4.0.0 as a separate piece of work as and when it has been released.

@artembilan
Copy link
Member

Sounds goos. So, let's merge!

@poutsma
Copy link
Contributor

poutsma commented May 13, 2014

Merged. Thanks!

@poutsma poutsma closed this May 13, 2014
@wilkinsona wilkinsona deleted the smack-dependency branch May 13, 2014 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants