Add the Spring IO plugin #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
build.gradle
Outdated
Member
Author
There was a problem hiding this comment.
Sorry, that was a leftover from my testing against a local build of the platform. I'll update the PR.
Member
|
I see Spring WS has custom ? |
Member
Author
|
Thanks for spotting that, Artem. Unlike the problems with had with SI, Spring WS builds cleanly without making that change. That said, it's probably a good idea to apply the same configuration. |
Configure the Spring IO plugin such that it's only applied when the build is run with -PplatformVersion=<version>. This platformVersion property is used to determine the version of the Platform that will be used when running the springIoCheck task. The plugin can be used by running a build as follows: ./gradlew clean springIoCheck -PplatformVersion=1.0.0.BUILD-SNAPSHOT -PJDK8_HOME=… This will test the project on JDK 8 using the dependencies defined in the latest snapshot of Spring IO Platform 1.0.0.
Member
|
I can't say LGTM, because I don't have WS sources to check it localy. |
Contributor
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Configure the Spring IO plugin such that it's only applied when the build is run with
-PplatformVersion=<version>. ThisplatformVersionproperty is used to determine the version of the Platform that willbe used when running the
springIoChecktask. The plugin can be used by running a build as follows:This will test the project on JDK 8 using the dependencies defined in the latest snapshot of Spring IO Platform 1.0.0.