Add the battery size as an output #2424
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgazza
force-pushed
the
record-battery-size
branch
from
b57786d to
bd4fd19
Compare
adds a new dashboard_item for .soc_max_kw using pred.soc_max so that total battery capacity in kWh is visible in the UI uses same formatting as soc_kw
mgazza
force-pushed
the
record-battery-size
branch
from
bd4fd19 to
8fb56a8
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new dashboard item to output the total system battery size in kWh.
- Introduces a new dashboard item using self.dashboard_item for battery size.
- Uses dp3 to process the value from self.soc_max for display.
Comments suppressed due to low confidence (1)
apps/predbat/plan.py:3187
- [nitpick] The variable name 'soc_max' may be ambiguous given that it represents the total battery size. Consider renaming it to something more descriptive such as 'total_battery_size' to improve code clarity.
state=dp3(self.soc_max),
Owner
|
Any reason why this can't just be an attribute in soc_kw? |
Collaborator
Author
|
Nope none. |
Add soc_percent to an attribute also
Owner
|
Will re-do this with an attribute |
Collaborator
Author
|
@springfall2008 you may want to look at the last commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Punting out the total battery size of the system