Fix minute_data function parameter consistency #2719
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…st_days The minute_data function has a 'days' parameter but was incorrectly using self.forecast_days in one location (line 655) when calculating to_time. This could cause inconsistent behavior when the function is called with a different days value than self.forecast_days. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
minute_datafunctionself.forecast_daysinstead of thedaysparameter in one locationBug Description
The
minute_datafunction accepts adaysparameter but was incorrectly usingself.forecast_dayson line 655 when calculatingto_time. This could cause inconsistent behavior when the function is called with a different days value thanself.forecast_days.Changes Made
self.forecast_daystodaysparameter for consistencyImpact
🤖 Generated with Claude Code