Tidy #2922
Merged
Tidy #2922
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR performs code cleanup by moving the import time statement to module-level scope and removing unnecessary runtime checks. The changes improve code organization by following Python best practices of placing imports at the top of files rather than inside functions.
- Moved
import timefrom function-local to module-level scope in plan.py and execute.py - Removed unnecessary
hasattr()check foroctopus_intelligent_chargingattribute
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| apps/predbat/plan.py | Moved import time from inside calculate_plan() method to module-level imports |
| apps/predbat/execute.py | Moved import time from inside execute_plan() method to module-level imports and removed unnecessary hasattr() check for octopus_intelligent_charging |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
iangregory
pushed a commit
to iangregory/batpred
that referenced
this pull request
Dec 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.