Minor fixes, Add entity list viewer to components web page#3097
Minor fixes, Add entity list viewer to components web page#3097springfall2008 merged 2 commits intomainfrom
Conversation
Add entity list viewer to components
There was a problem hiding this comment.
Pull request overview
This PR adds an entity list viewer to the components web page and includes minor bug fixes. The main feature allows users to click on entity counts in the components view to see a detailed, searchable list of matching entities in a modal popup.
Key changes:
- Adds interactive modal popup for viewing entities matching component filters
- Fixes potential crash in predheat.py when history data returns empty arrays
- Bumps version to v8.30.1
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| apps/predbat/web_helper.py | Adds CSS styling and JavaScript functions for the new entity modal popup with search functionality and dark mode support |
| apps/predbat/web.py | Implements API endpoint /component_entities and integrates entity modal into components page with clickable entity counts |
| apps/predbat/predheat.py | Adds safety check to verify history arrays are not empty before accessing elements, preventing index out of bounds errors |
| apps/predbat/predbat.py | Version bump from v8.30.0 to v8.30.1 |
| apps/predbat/components.py | Adds missing event_filter field for Axle Energy component to support entity filtering |
|
|
||
| text += f"</div>\n" | ||
| text += f"</div>\n" |
There was a problem hiding this comment.
The HTML attribute syntax is malformed. The onclick attribute is being concatenated directly after the style attribute without proper spacing. The closing quote for style attribute is missing, and the opening quote for the onclick attribute value is misplaced. This will result in invalid HTML. The attributes should be properly separated with spaces.
…l2008#3097) * Minor fixes Add entity list viewer to components * [pre-commit.ci lite] apply automatic fixes --------- Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
1 participant
No description provided.