Fix issue where fdSoc can not be less than minSocOnGrid #3104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in the Fox API battery schedule logic where the force discharge SOC (fdSoc) could be set lower than the minimum SOC on grid (minSocOnGrid/reserve), which would cause incorrect battery behavior. The fix ensures fdSoc is always at least as high as the reserve level by using max(soc, reserve).
Key changes:
- Applied
max(soc, reserve)tofdSocin discharge schedules to prevent it from being lower than reserve - Removed unused
getMinSocOnGridmethod - Updated test expectations to verify the fix works correctly
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| apps/predbat/fox.py | Fixed discharge schedule to ensure fdSoc is never lower than reserve using max(soc, reserve), and removed unused getMinSocOnGrid method |
| apps/predbat/tests/test_fox_api.py | Updated test assertion from fdSoc == 10 to fdSoc == 15 to verify the fix correctly applies max(soc, reserve) when soc=10 and reserve=15 |
iangregory
pushed a commit
to iangregory/batpred
that referenced
this pull request
Dec 24, 2025
…08#3104) * Fix issue where fdSoc can not be less than minSocOnGrid * Version bump
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3063