fix: handle string entries in dashboard_values in _execute_get_entities#3500
Merged
springfall2008 merged 1 commit intospringfall2008:mainfrom Mar 5, 2026
Conversation
dashboard_values contains mixed types — some entries are plain strings
(entity IDs) rather than dicts. Calling .get() on a string raises:
AttributeError: 'str' object has no attribute 'get'
Fix: check isinstance(entity, str) before calling .get(), treating string
entries as bare entity IDs with no additional attributes.
Fixes springfall2008#3498
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AttributeError: 'str' object has no attribute 'get'when calling theget_entitiesMCP tooldashboard_valuescontains mixed types — some entries are plain strings (entity IDs) rather than dictsisinstance(entity, str)before calling.get(), treating string entries as bare entity IDsFixes #3498