Fix accuracy in calibration of solar#3607
Merged
springfall2008 merged 6 commits intomainfrom Mar 20, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates Predbat’s solar PV forecast calibration to improve numerical accuracy by refining how historical PV/forecast data is sampled and how scaling factors are applied across future forecast days, and adds a synthetic regression test to validate key calibration outputs.
Changes:
- Update
SolarAPI.pv_calibration()to use a 7-day history window (fetching 8 days for data availability) and compute worst/best scaling relative to an average-day scaling factor. - Add per-forecast-day scaling compensation so future-day totals remain consistent after applying per-slot adjustments.
- Add a new synthetic-value calibration test case and bump Predbat version to
v8.34.7.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| apps/predbat/solcast.py | Adjusts PV calibration algorithm (history window, average/worst/best scaling logic, and per-day scaling correction). |
| apps/predbat/tests/test_solcast.py | Updates existing calibration tests for the new signature and adds a synthetic regression test covering key numeric expectations. |
| apps/predbat/predbat.py | Bumps version from v8.34.6 to v8.34.7. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.