Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes Solis V1 time-window slot detection using the correct (local) clock so Predbat doesn’t disable timed charge/discharge during an active forced discharge window (issue #3803).
Changes:
- Use
self.now_utc_exact(local timezone) for V1 slot comparisons instead ofdatetime.now(UTC). - Update Solis tests to mock the current time via an overridable
now_utc_exactand add regressions covering discharge-slot detection and local-vs-UTC behavior.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| apps/predbat/solis.py | Switch V1 slot detection to use local-time (now_utc_exact) when determining whether the current time is inside a charge/discharge window. |
| apps/predbat/tests/test_solis.py | Add/adjust V1 regression tests to validate correct discharge-slot detection and guard against UTC/local mismatch. |
Comment on lines
+12
to
+13
| from datetime import datetime | ||
| from unittest.mock import MagicMock |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#3803