Fix Solax charging issue and load issue#3823
Merged
springfall2008 merged 12 commits intomainfrom Apr 23, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to fix two SolaX Cloud integration issues: (1) scheduled charge/export windows that span midnight not being applied correctly, and (2) incorrect/absent load power reporting by introducing a dedicated load_power sensor derived from inverter + battery + grid telemetry.
Changes:
- Updated
apply_controls()to better detect charge/export windows that span midnight. - Added per-plant
load_powerpublishing and wiredautomatic_config()to reference it (plus setbattery_power_invertand fixbattery_rate_maxarg name). - Extended SolaX tests to cover midnight-spanning windows and load power calculation; updated cspell dictionary entries.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
| apps/predbat/solax.py | Adjusts midnight window handling; updates auto-config args; adds computed load_power publishing from realtime data. |
| apps/predbat/tests/test_solax.py | Adds regression tests for midnight-spanning windows and load_power calculation (including None battery power). |
| .cspell/custom-dictionary-workspace.txt | Adds nobat and normalizes nordpool entry. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
Comments suppressed due to low confidence (1)
apps/predbat/solax.py:2041
publish_device_realtime_data()logs the full real-time payload for every device on every publish cycle. Since this runs regularly (e.g., once per minute) this can spam logs and leak large payloads into HA/AppDaemon logs. Please guard this behind a debug flag / log-level check, or remove it (keeping only concise summaries when needed).
if device_type == 1: # Inverter
device_model = SOLAX_DEVICE_MODEL_RESIDENTIAL.get(1, {}).get(device_model_code, "Unknown Inverter")
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.