Skip to content

Fix Solax charging issue and load issue#3823

Merged
springfall2008 merged 12 commits intomainfrom
fix/solax3
Apr 23, 2026
Merged

Fix Solax charging issue and load issue#3823
springfall2008 merged 12 commits intomainfrom
fix/solax3

Conversation

@springfall2008
Copy link
Copy Markdown
Owner

No description provided.

Copilot AI review requested due to automatic review settings April 23, 2026 19:51
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to fix two SolaX Cloud integration issues: (1) scheduled charge/export windows that span midnight not being applied correctly, and (2) incorrect/absent load power reporting by introducing a dedicated load_power sensor derived from inverter + battery + grid telemetry.

Changes:

  • Updated apply_controls() to better detect charge/export windows that span midnight.
  • Added per-plant load_power publishing and wired automatic_config() to reference it (plus set battery_power_invert and fix battery_rate_max arg name).
  • Extended SolaX tests to cover midnight-spanning windows and load power calculation; updated cspell dictionary entries.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 7 comments.

File Description
apps/predbat/solax.py Adjusts midnight window handling; updates auto-config args; adds computed load_power publishing from realtime data.
apps/predbat/tests/test_solax.py Adds regression tests for midnight-spanning windows and load_power calculation (including None battery power).
.cspell/custom-dictionary-workspace.txt Adds nobat and normalizes nordpool entry.

Comment thread apps/predbat/solax.py
Comment thread apps/predbat/solax.py Outdated
Comment thread apps/predbat/solax.py Outdated
Comment thread apps/predbat/solax.py Outdated
Comment thread apps/predbat/solax.py Outdated
Comment thread apps/predbat/solax.py Outdated
Comment thread apps/predbat/tests/test_solax.py
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

Comments suppressed due to low confidence (1)

apps/predbat/solax.py:2041

  • publish_device_realtime_data() logs the full real-time payload for every device on every publish cycle. Since this runs regularly (e.g., once per minute) this can spam logs and leak large payloads into HA/AppDaemon logs. Please guard this behind a debug flag / log-level check, or remove it (keeping only concise summaries when needed).

            if device_type == 1:  # Inverter
                device_model = SOLAX_DEVICE_MODEL_RESIDENTIAL.get(1, {}).get(device_model_code, "Unknown Inverter")

Comment thread apps/predbat/solax.py Outdated
Comment thread apps/predbat/solax.py Outdated
Comment thread apps/predbat/solax.py Outdated
springfall2008 and others added 5 commits April 23, 2026 21:14
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@springfall2008 springfall2008 merged commit 16c3048 into main Apr 23, 2026
1 check passed
@springfall2008 springfall2008 deleted the fix/solax3 branch April 23, 2026 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants