Fix duplicate octopus slots#3905
Merged
springfall2008 merged 5 commits intomainfrom May 11, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to prevent duplicate Octopus Intelligent dispatch slots (typically a completed dispatch plus a planned dispatch for the same time range) from being applied twice, which can incorrectly consume the midday-to-midday cheap-slot cap and/or duplicate rate adjustments.
Changes:
- Add test coverage for completed+planned duplicate dispatches and cap-budget behavior.
- Add a deduplication step when merging historical completed dispatches.
- Add duplicate-suppression logic in
rate_add_io_slots()to avoid double-applying the same slot minutes.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
apps/predbat/tests/test_rate_add_io_slots.py |
Adds new regression tests for duplicate dispatch suppression and cap-budget preservation. |
apps/predbat/octopus.py |
Introduces deduplication of completed dispatches and attempts to suppress duplicate IO slots when applying rate overrides. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.