Fix/gateway json#4020
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves the Gateway MQTT component’s handling of gateway_inverter_serial when it is provided as a JSON-encoded string (e.g. a JSON array), adds unit tests covering the new parsing behavior, and bumps the PredBat version.
Changes:
- Parse JSON-encoded
gateway_inverter_serialstrings inGatewayMQTT.initialize()(arrays become lists; non-arrays are stringified and wrapped). - Add tests for JSON array/object/invalid-JSON handling of the serial filter.
- Bump
THIS_VERSIONand add a couple of local/dev ignore entries to.gitignore.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| apps/predbat/gateway.py | Extends serial-filter normalization to support JSON-encoded strings. |
| apps/predbat/tests/test_gateway.py | Adds coverage for the new JSON serial-filter parsing behavior. |
| apps/predbat/predbat.py | Version bump to v8.39.16. |
| .gitignore | Ignores additional local/dev artifacts. |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.