Gateway, prevent auto-config if filter does not match#4026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR changes GatewayMQTT auto-configuration behavior so that when gateway_inverter_serial is configured but matches no inverters, the gateway does not proceed with auto-config and instead logs an error and retries on subsequent telemetry. This aims to prevent binding PredBat to an unintended inverter set.
Changes:
- Update
GatewayMQTT.automatic_config()to treat a serial-filter no-match as an error and abort auto-config early. - Update gateway unit tests to expect aborted auto-config and an error log when the serial filter matches nothing.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| apps/predbat/gateway.py | Aborts auto-config when gateway_inverter_serial matches no inverters, logging an error and returning early. |
| apps/predbat/tests/test_gateway.py | Updates/renames the serial-filter no-match test to assert _auto_configured remains false and num_inverters is not set. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.