remove Pvlib that uses 60MB of ram#4027
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the pvlib dependency (noted as consuming significant RAM) and replaces its limited usage in the Solcast integration with an equivalent inline SAPM/PVWatts cell temperature calculation, keeping solar forecast temperature-derating behavior without requiring pvlib.
Changes:
- Removed
pvlibfromrequirements.txt. - Deleted conditional
pvlibimport/usage inapps/predbat/solcast.pyand standardized on an inline SAPM/PVWatts formula for cell temperature.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| requirements.txt | Drops the pvlib dependency from the install set. |
| apps/predbat/solcast.py | Replaces pvlib.temperature.sapm_cell usage with an equivalent inline SAPM/PVWatts computation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.