GECloud: Fix to avoid turning on real time mode for EMS as its not supported#4143
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the GECloud default-settings logic to avoid attempting to enable “Real Time Control” when an EMS device is detected, and adds regression coverage to ensure no RTC write is attempted in that scenario.
Changes:
- Skip RTC enablement in
GECloud.enable_default_options()whenems_deviceis present. - Add a unit test case ensuring RTC is not written (and returns
False) when an EMS device exists. - Renumber subsequent test labels accordingly.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| apps/predbat/gecloud.py | Skips enabling real-time control when an EMS device is present. |
| apps/predbat/tests/test_ge_cloud.py | Adds regression test coverage for EMS-present RTC skip behavior. |
| self.log("GECloud: Warn: Failed to set {} for {}".format(ha_name, device)) | ||
| if "real_time_control" in ha_name: | ||
| if self.ems_device: | ||
| # RTC is on the EMS, not the individual inverters — skip |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.