Add numpy to requirements.txt #95
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the Python dependencies for the predbat project by adding numpy to requirements.txt.
Changes:
- Add
numpyas a new dependency inpredbat/requirements.txt.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| Jinja2 | ||
| ruamel.yaml==0.18.17 | ||
| pyjwt | ||
| numpy |
There was a problem hiding this comment.
The numpy dependency is being added here but there are currently no references to it elsewhere in the codebase, so this introduces an unused dependency that will increase install size and maintenance overhead. Unless there is code in this PR (or a tightly-coupled upcoming PR) that requires numpy, consider omitting it for now and adding it only when there is a concrete use.
| numpy |
| Jinja2 | ||
| ruamel.yaml==0.18.17 | ||
| pyjwt | ||
| numpy |
There was a problem hiding this comment.
Adding numpy as an unpinned dependency means builds will always pull the latest release from PyPI, which creates a supply-chain risk if the package or registry is ever compromised. Because this library code will execute in your application context (e.g., on import or during install), a malicious release could exfiltrate secrets or run arbitrary code. Pin numpy to a specific version (and consider pinning other third-party dependencies in this file) so upgrades happen in a controlled way after review.
No description provided.