Skip to content

Support for composite decorators #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Feb 15, 2017
Merged

Support for composite decorators #41

merged 13 commits into from
Feb 15, 2017

Conversation

@thibaudcolas
Copy link
Collaborator

@thibaudcolas thibaudcolas commented Feb 15, 2017

See #17.

su27 and others added 13 commits February 8, 2017 13:45
@su27 @thibaudcolas
Implement composite decorators (#17)
5be127a 
Initial work by @su27 in PR #17, then rebased and refactored.

- add composite decorator
- fix link decorator
- Implement decorator with DOM
- decorators should know the current block type
- fix composite decorator
@thibaudcolas
Change line break implementation to use decorators
4b34ef8
@thibaudcolas
Rename all the things
bcce0b4
@thibaudcolas
Start refactoring composite decorators
c6ff422
@thibaudcolas
Pass block_type to style_state instead of whole block
9d3ddf7
@thibaudcolas
Remove all decorator logic from style_state
9e8fbfc
@thibaudcolas
Finish splitting composite decorators from entities and styles
06892cc
@thibaudcolas
Bail out of decorators and entities if there are none
a212e5a
@thibaudcolas
Change decorators API to use render method
4422237
@thibaudcolas
Add tests for composite decorators
3df1496
@thibaudcolas
Rename decorators variable
d8657d9
@thibaudcolas
Add more decorators tests
72c4e1e
@thibaudcolas
Add release notes & succinct docs for decorators feature. Fix #16
66ae5ec
@thibaudcolas thibaudcolas added the enhancement New feature or request label Feb 15, 2017
@coveralls
Copy link

coveralls commented Feb 15, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 66ae5ec on feature/composite-decorators into 852d9ee on master.

2 similar comments
@coveralls
Copy link

coveralls commented Feb 15, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 66ae5ec on feature/composite-decorators into 852d9ee on master.

@coveralls
Copy link

coveralls commented Feb 15, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 66ae5ec on feature/composite-decorators into 852d9ee on master.

@thibaudcolas thibaudcolas merged commit 4397f97 into master Feb 15, 2017
@thibaudcolas thibaudcolas deleted the feature/composite-decorators branch February 15, 2017 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@thibaudcolas @coveralls @su27