-
Notifications
You must be signed in to change notification settings - Fork 115
Chore/remove redundant demos #180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
There's still a TODO on here, and the render-prop one will need updating too. But no dramas - only merging to a WIP branch. |
| </h3> | ||
| </AccordionItemHeading> | ||
| <AccordionItemPanel> | ||
| <Accordion allowMultipleExpanded={true}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure, was it valuable to show that you can put accordions inside accordions?
I'd also make sure that we still have some demo content that has a link or two inside the panel so we can demonstrate that tabbing to those will still work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I would consider re-instating the nested one. My thinking was that this demo could afford to be a lot more minimal, and that by showing too many different patterns it was becoming overwhelming.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, good idea re simplifying.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Links are a good idea... I'll whack some of those in there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Links there now @samanthaksanders. Going to merge now, and will revisit the nested accordion when I come back to do the 'TODOs'
A big re-jig of the demo page and a couple of little updates to the getting-started example boilerplate.
Notes:
AccordionItemHeading, which as we now know, is not permitted (only "phrasing content" is allowed inside a button).AccordionItemHeadinghave been removed in both the demo and the README.react react-domfrom the install line in the README. It's a bit redundant - if people don't already have React installed then they're in the wrong place.