Chore/update tests #50
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincentaudebert
suggested changes
Feb 26, 2018
Contributor
vincentaudebert
left a comment
vincentaudebert
left a comment
There was a problem hiding this comment.
@ryami333 Could you double check the CI tests if this is ready to be merged?
…ifferent className' test instead of snapshot
…ifferent hideBodyClassName' test instead of snapshot
ryami333
force-pushed
the
chore/update-tests
branch
from
f6ad4cc to
ff29cbd
Compare
Contributor
Author
|
Yup @vincentaudebert this is all gravy, ready to merge. |
vincentaudebert
approved these changes
Feb 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per comments on the big v2.0.0 PR, there were areas where the tests could have been updated, namely: