Feature/publish flow types #54
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Note: no breaking changes. Publishing will require a bump to the 'patch' version only. |
vincentaudebert
approved these changes
Feb 27, 2018
Contributor
vincentaudebert
left a comment
vincentaudebert
left a comment
There was a problem hiding this comment.
Looks sweet! Thanks Mitch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you do
import foo from 'react-accessible-accordion/foo';then Flow first looks forfoo.js.flowfor typing information. This means that if you publish all your source files intodist/but you rename them*.flowthen your users get Flow types without any additional configuration (eg. no need to use Flow-Typed).The package
flow-copy-sourcewas created for this very purpose - it just copies everything fromsrc/todist/and appends.flowto all the file names.See here for discussion.
Closes #51.