Feature/respect arbitrary props #55
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincentaudebert
approved these changes
Feb 27, 2018
| type AccordionItemTitleProps = { | ||
| children: Node, | ||
| className: string, | ||
| type AccordionItemTitleProps = ElementProps<'div'> & { |
There was a problem hiding this comment.
Interesting one :)
ryami333
force-pushed
the
feature/respect-arbitrary-props
branch
from
13e1d4d to
8210a47
Compare
ryami333
force-pushed
the
feature/respect-arbitrary-props
branch
from
8210a47 to
4ca313c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now, any extra props you pass to any RAA elements get swallowed by the element. This PR adds the ability to propagate any additional props.
Eg.
Note: backwards-compatible change to the API, so this will require a bump to the 'minor' version.
Closes #53.