Skip to content

feat(dist): search#686

Merged
maxschmalenbach merged 23 commits intomainfrom
feat(dist)/search
Feb 27, 2026
Merged

feat(dist): search#686
maxschmalenbach merged 23 commits intomainfrom
feat(dist)/search

Conversation

@maxschmalenbach
Copy link
Copy Markdown
Collaborator

@maxschmalenbach maxschmalenbach commented Feb 19, 2026

🗒 Description

Add feature to search IEDs, APs, LDevices, LNodes. Update results live.
Added InputGroup shadcn component.

📷 Demo screen recording or Screenshots

Screen.Recording.2026-02-20.at.12.51.58.mp4

📋 Checklist

You may remove tasks that do not make sense in this PR.

  • Ticket-ACs are checked and met
  • GitHub labels are assigned
  • Git Ticket / issue is linked with PR
  • Designated PR Reviewers are set
  • Tested by another developer
  • Changelog updated
  • Documentation updated (check Documentation guidelines for further reading )
  • All comments in the PR are resolved / answered

🔦 Useful commits

You can add specific commits which are worth taking a look into

❌ Link issue(s) to close - hint

closes #574

@maxschmalenbach
Copy link
Copy Markdown
Collaborator Author

For future refactoring of scl:

Files to move INTO scl/ in a future refactor

Source Target Content
matching/scd-edits/bay-edits.ts scl/edits/bay-edits.ts Bay update edits
matching/scd-edits/function-edits.ts scl/edits/function-edits.ts Function/EqFunction insert edits
matching/scd-edits/delete-edits.ts scl/edits/delete-edits.ts Delete AccessPoint/LNode edits
matching/scd-edits/data-type-edits.ts scl/edits/data-type-edits.ts DataTypeTemplates edits (if exists)
Data-type queries (if any) scl/queries/data-type-queries.ts queryDOTypes, queryDATypes, etc.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this a good idea? To move them together 🤔

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

structured into ied, bay, accesspoint edits

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still have Accespoint stuff here. But maybe its private should maybe not export it then?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its being used in the ied-ap-form, ill move it to accesspoint-edits

@tmenzel27
Copy link
Copy Markdown
Collaborator

I still have to test locally but I can smell merge conflicts with my PR 🙈

Comment thread packages/plugins/type-distributor/src/headless/scl/edits/ied-edits.ts Outdated
Comment thread packages/plugins/type-distributor/src/headless/scl/edits/lnode-edits.ts Outdated
Comment thread packages/plugins/type-distributor/src/headless/scl/edits/lnode-edits.ts Outdated
Comment thread packages/plugins/type-distributor/src/headless/scl/edits/lnode-edits.ts Outdated
@maxschmalenbach maxschmalenbach marked this pull request as ready for review February 23, 2026 12:03
@tmenzel27 tmenzel27 changed the title Feat(dist)/search feat(dist): search Feb 23, 2026
Comment thread packages/plugins/type-distributor/src/headless/scl/edits/accesspoint-edits.ts Outdated
Comment thread packages/plugins/type-distributor/src/headless/scl/edits/bay-edits.ts Outdated
Comment thread packages/plugins/type-distributor/src/headless/scl/queries/ied-queries.ts Outdated
Comment thread packages/plugins/type-distributor/src/headless/scl/filters/types.d.ts Outdated
Copy link
Copy Markdown
Collaborator

@tmenzel27 tmenzel27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but am just human 🤣

Comment thread packages/plugins/type-distributor/CHANGELOG.md
@maxschmalenbach maxschmalenbach merged commit 99c7f01 into main Feb 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Search for S-IEDs and APs in it

3 participants