-
Notifications
You must be signed in to change notification settings - Fork 2
deploy: fix actions triggers #79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Closes #78 |
trusz
approved these changes
Sep 18, 2024
Collaborator
trusz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice catch
michelguerin
added a commit
that referenced
this pull request
Oct 4, 2024
* feat: init - instantiate canvas boilerplate - add xml queries to read LDType from .scd * feat: add primitive bay node design * feat: add control buttons and remaining search queries (dirty version) - add remaining search queries, their wrappers and types - complete the prototype version of showing all variations of types available - add buttons to add new types (inactive) - small refactor of bay component * perf(ce): Limit GSEControl querry to parent (#51) * perf: Limit GSEControl querry to parent * perf: Search in correct IED for control * feat: correctly show fetched nodes * fix: show props only if value exists * feat: write to SCD: v.0.1 * feat(ce): increment version to trigger github action (#77) * deploy: fix actions triggers (#79) * deploy: test actions trigger * deploy: increment communication explorer plugin version for test purpose * deploy: reverse version increment on communication explorer plugin as test is done * deploy: change paths that triggers the actions to reflect the monorepo tree * fix: correctly pass event to its dispatcher * fix: typo in variable name * Deploy: fix github actions authentication (#81) * deploy: test actions trigger * deploy: increment communication explorer plugin version for test purpose * deploy: reverse version increment on communication explorer plugin as test is done * deploy: change paths that triggers the actions to reflect the monorepo tree * deploy: change the way action script is pushing to the gh-pages branch as per the docs * deploy: increment communication explorer plugin version for test purpose * deploy: change the fit push command on build.yml to use the GITHUB_TOKEN * deploy: increment communication explorer plugin version for test purpose * deploy: comment out secrets in build:yml * deploy: increment communication explorer plugin version for test purpose * deploy: comment out secrets in plugin_communication-explorer.yml * deploy: increment communication explorer plugin version for test purpose * deploy: reverse version increment on communication explorer plugin as test is done * deploy: remove all personal token references in favor of the GITHUB_TOKEN * deploy: remove the trigger for this specific branch * feat: events setup - auto update doc on important changes * feat: correct nodes options * feat: node component * feat: small clean-up * feat: complete event list - full functionality * feat: add primitive node configuration * fix: re-add deleted searchLNodeTypes * fix: correct event receiving model * feat: clean-up * fix: update todo * feat: real-time doc update on createNode + fix wrong names in scd * chore: clean-up * chore: clean-up * feat(type-designer): rework of the plugin I reworked this draft to allow myself to enter both in svelte and the project. I simplified the business logic which I transferred to the core package (separate PR). * Structure convention on Core (#85) * feat(type-designer): rewrite of the typedesigner logic + new structure convention New structure convention can be found as ADR 0004 It is used here for the implementation of the new type designer logic Some unused files have been moved to a specific folder waiting approval before deletion * feat(adr): add more precisions to the adr * Add biome as linter (in place of eslint) and formatter (#86) * feat(global): add biome as linter (in place of eslint) and formatter * feat(monorepo): remove vscode settings from source control * feat(monorepo): change biome formatter indent width to 4 * feat: init - instantiate canvas boilerplate - add xml queries to read LDType from .scd * feat: add primitive bay node design * feat: add control buttons and remaining search queries (dirty version) - add remaining search queries, their wrappers and types - complete the prototype version of showing all variations of types available - add buttons to add new types (inactive) - small refactor of bay component * feat: correctly show fetched nodes * fix: show props only if value exists * feat: write to SCD: v.0.1 * fix: correctly pass event to its dispatcher * fix: typo in variable name * feat: events setup - auto update doc on important changes * feat: correct nodes options * feat: node component * feat: small clean-up * feat: complete event list - full functionality * feat: add primitive node configuration * fix: re-add deleted searchLNodeTypes * fix: correct event receiving model * feat: clean-up * fix: update todo * feat: real-time doc update on createNode + fix wrong names in scd * chore: clean-up * chore: clean-up * feat(type-designer): rework of the plugin I reworked this draft to allow myself to enter both in svelte and the project. I simplified the business logic which I transferred to the core package (separate PR). * Structure convention on Core (#85) * feat(type-designer): rewrite of the typedesigner logic + new structure convention New structure convention can be found as ADR 0004 It is used here for the implementation of the new type designer logic Some unused files have been moved to a specific folder waiting approval before deletion * feat(adr): add more precisions to the adr * feat(type-designer): change minor things after review + biome formatting core and type designer --------- Co-authored-by: Illia Solovei <illia.solovei@deutschepost.de> Co-authored-by: Christopher Lepski <139237321+clepski@users.noreply.github.com> Co-authored-by: Michel Guerin <100696308+michelguerin@users.noreply.github.com> Co-authored-by: Michel Guerin <dev@guerin.at>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress
Related to #78