fix: prevent started process starting again#160
Merged
Conversation
mpetrun5
requested review from
MakMuftic,
mpetrunic and
tcar121293
as code owners
|
Go Test coverage is 53.7 %\ ✨ ✨ ✨ |
MakMuftic
previously approved these changes
Mar 3, 2026
mpetrunic
requested changes
Mar 3, 2026
|
Go Test coverage is 53.7 %\ ✨ ✨ ✨ |
mpetrunic
previously approved these changes
Mar 3, 2026
MakMuftic
previously approved these changes
Mar 3, 2026
There was a problem hiding this comment.
Pull request overview
This PR aims to prevent ECDSA TSS processes (keygen/resharing/signing) from being started multiple times, and centralizes the coordinator’s goroutine startup logic.
Changes:
- Added
Started+ mutex gating toRun()in keygen/resharing/signing, with a sharedErrProcessStarted. - Refactored coordinator process-start goroutine into
Coordinator.startProcess. - Changed default signing timeout (from 30s to 8s).
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
tss/ecdsa/common/base.go |
Adds shared ErrProcessStarted and Started/mutex fields to the common base struct. |
tss/ecdsa/keygen/keygen.go |
Adds “already started” guard to prevent duplicate Run() execution. |
tss/ecdsa/resharing/resharing.go |
Adds “already started” guard to prevent duplicate Run() execution. |
tss/ecdsa/signing/signing.go |
Adds “already started” guard and changes signing timeout default. |
tss/coordinator.go |
Uses a helper to start processes and attempts to ignore ErrProcessStarted. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Go Test coverage is 53.7 %\ ✨ ✨ ✨ |
|
Go Test coverage is 53.7 %\ ✨ ✨ ✨ |
MakMuftic
approved these changes
Mar 3, 2026
mpetrunic
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issue Or Context
Closes: #
How Has This Been Tested? Testing details.
Types of changes
Checklist: