Fix default live room entrypoint#314
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the v0.9.4 product mismatch where plain
crstill opened the read-only dashboard first and then fell through to the old REPL. Plaincrnow opens the unified live room directly for initialized interactive projects;cr startremains the explicit legacy/direct REPL escape hatch, andcr consoleremains the read-only dashboard/snapshot inspection surface.Closes #313
Acceptance Criteria
crin an initialized interactive project enters the unified live room directly.crdoes not printCoreRoom console closed; starting REPLon normal exit.crdoes not fall through to the old splash/REPL after leaving the live room.cr startremains the explicit legacy/direct REPL escape hatch.cr consoleremains the read-only dashboard/snapshot inspection surface.cr console --live-roomremains accepted as an explicit alias to the same unified room.@roletext through plaincr.Changed Files
src/main.rsswitches the default initialized TTY path from read-only console + REPL fallback to unified live room.src/console_tui.rsseparates live-room composer hints from read-only dashboard hints.scripts/dogfood-v09-user-cases.pynow tests typed input through plaincr, not onlycr console --live-room.Validation
cargo fmt --all -- --checkcargo test --all-features --locked --quietcargo clippy --all-targets --all-features --locked -- -D warningscargo build --release --lockedtarget/release/cr --version->cr 0.9.5cd npm && npm pack --dry-run --json->@spytensor/coreroom@0.9.5python3 scripts/dogfood-v09-user-cases.py->DOGFOOD PASS: v0.9 local user-case gate completedReal PTY Evidence
The dogfood script now opens plain
crin a 160x48 PTY, waits forComposer, types:It asserts visible
CoreRoom,Project,Conversation,Composer,Environment,Roles,queued for @host, explicit@rolerouting, and rejectsCoreRoom console closed; starting REPLplus the old REPL splash hint.Risk / Rollback
Risk is isolated to interactive default entrypoint behavior. Roll back by reverting this PR;
cr startremains the explicit old REPL path throughout.