Ship fake-engine dogfood and TUI default#338
Merged
Merged
Conversation
This was referenced May 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #332
Updates #320
Summary
Engine::FakebehindCOREROOM_ENABLE_FAKE_ENGINE=1, implemented through the existingEngineAdapterpath with deterministic chunked output and a permission-bridge probe.crto the executable full-screen TUI room from v0.9.x: implement TuiSink and ratatui room hosting run_with_options_and_sink #331. Non-TTY plaincrstill falls back to the stdout runtime;cr startremains the explicit stdout entrypoint;cr consoleremains the read-only dashboard;cr console --live-roomis the explicit TUI-room spelling..coreroom/messages.jsonlevents, then regenerates README images and updates v0.9.8 release docs/splash/version metadata.Acceptance Criteria
EngineAdapter; response text and chunk timing are env-configurable; no network/API path.COREROOM_ENABLE_FAKE_ENGINE=1; config validation and--engine fakereject it unless explicitly enabled.scripts/dogfood-v09-user-cases.pydrives the TUI room over PTY and checks idle/working status, streamed chunks, durable messages, and permission overlay behavior.docs/v0.9-real-user-dogfood.mdanddocs/v0.9.4-live-room-dogfood.mdnow describe behavioral proof and authenticated-engine non-goals.run_console_first_defaultroutes interactive plaincrto the TUI room;cr startandcr consolekeep their existing roles.make readme-imagesran via dogfood.Validation
cargo fmt --all -- --checkpassed.git diff --checkpassed.cargo clippy --all-targets --all-features --locked -- -D warningspassed.cargo test --all-features --lockedpassed: 608 lib tests passed, 1 ignored, integration/doc tests passed.python3 scripts/dogfood-v09-user-cases.pypassed, including PTY plaincr, fake-engine streaming, permission overlay, durablemessages.jsonl,cr console --live-room, read-only console paths, Nerd Font mode, andmake readme-images.Evidence Packet
The dogfood run proves executable-equivalent default behavior without quota burn:
cr --versionreportedcr 0.9.8.crin a PTY rendered the TUI composer, dispatched fake-engine turns, showedidleandworking, renderedfake-stream-1throughfake-stream-3, opened theFakeToolpermission overlay, accepted denial, and renderedfake-permission-denied..coreroom/messages.jsonlgainedturn_dispatched,role_spoke, andpermission_deniedevents with real turn ids.cr console --live-roomopened the executable TUI room.cr consoleandcr console --snapshotremained read-only dashboard paths.make readme-imagesregenerateddocs/images/boot-dashboard.png,docs/images/work-cards.png, anddocs/images/control-room-console.png; onlyboot-dashboard.pngchanged with v0.9.8 splash copy.Changed Files Summary
src/adapter/fake.rs,src/adapter/mod.rs,src/repl.rs,src/main.rs,src/config*.rs,src/engines.rs, init/splash labels.scripts/dogfood-v09-user-cases.py, v0.9 dogfood docs, README, CHANGELOG, development notes, proposed amendment note.0.9.8,src/lib.rsdocs root, splash content, README image.Risks and Remaining Gaps
/tmp/cr-v09-*project path.Rollback Plan
Revert this PR to restore plain
crto the previous default path, remove the fake engine adapter, and restore the previous v0.9.7 docs/assets. If only the TUI default is problematic, revert therun_console_first_defaultchange and leavecr console --live-roomas the explicit executable TUI entrypoint.Tracker Update
After merge, update #320:
crnow defaults to the executable full-screen TUI room.