fix(runtime): prepare v0.9.19 hotfix#399
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #398.
Session not found for thread_idtext as@hostoutput.@uservisibly distinct in scrollback by using the prompt green identity color.TurnDispatchedbanner so normal user -> host turns do not double-label@host, while preserving real cross-role handoff banners.Changed files
src/adapter/codex.rs: stale Codex session detection/retry and tests.src/repl/render.rs,src/repl/tests.rs: suppress root host dispatch banner and cover it.src/console_room_runtime.rs: visible@useridentity color.Cargo.toml,Cargo.lock,src/lib.rs,npm/package.json,README.md,data/splash_content.toml,CHANGELOG.md: v0.9.19 release metadata.Acceptance criteria
@userscrollback label is visibly styled.Validation
cargo fmt --all -- --checkgit diff --checkenv -u NO_COLOR TERM=xterm-256color cargo test --quiet— 765 passed, 1 ignored in lib; smoke tests intentionally ignored.cargo clippy --all-targets --all-features -- -D warningscargo build --releasepython3 scripts/dogfood-v09-user-cases.py—cr 0.9.19,DOGFOOD PASS: v0.9 local user-case gate completed.Evidence packet
Local project evidence showed
.coreroom/sessions/ids/host.idcontained4028d717-299e-4039-b333-c615a041c197, and.coreroom/messages.jsonlrecorded the same stale id followed by an@hostrole_spoke event containingSession not found for thread_id: 4028d717-299e-4039-b333-c615a041c197. That made the root cause a stale Codex resume id being returned as tool text, not a new user thread.Risks and remaining gaps
Session not found for thread_id:text or a JSON-RPCmessagefield with that leading text. If Codex changes the wording, it will fall back to the existing error path.RoleSessionUpdatedevent to persist the fresh Codex thread id.Rollback plan
Revert this commit and release a corrective patch tag if the retry path regresses Codex session continuity or if the transcript rendering change hides a required handoff banner.
Tracker update
No milestone tracker update required; this is a direct v0.9.18 -> v0.9.19 maintainer hotfix tracked by #398.