Move docker/build_all.sh to travis/build_images.sh #2007
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Script files in docker/ are supposed to be called in the Dockerfile or copied into the Docker image. However,
build_all.shis not for those purposes. Instead, it invokes the commanddocker buildto build the images.build_all.shis (only) called in .travis.yml and it depends on$TRAVIS_BUILD_DIR, so I moved it toscripts/travis/build_images.sh.We have two places to set the base image: (1) in the Dockerfile and (2) in
build_all.sh. This is error-prone when a contributor wants to change the base image -- she might change only one of these two places. This PR removes the base image setting inbuild_all.sh.