Skip to content

Package Fluid distribution achieve#19

Merged
Yancey0623 merged 1 commit intosql-machine-learning:developfrom
Yancey0623:setup_egg
Mar 19, 2020
Merged

Package Fluid distribution achieve#19
Yancey0623 merged 1 commit intosql-machine-learning:developfrom
Yancey0623:setup_egg

Conversation

@Yancey0623
Copy link
Copy Markdown
Collaborator

@Yancey0623 Yancey0623 commented Mar 19, 2020 •
edited
Loading

This PR allows users to execute

> python setup.py sdist bdist_wheel
> pip install dist/*.whl

to package the distribution archive and install it on the project root.

@Yancey0623
Copy link
Copy Markdown
Collaborator Author

Yancey0623 commented Mar 19, 2020

Hi @wangkuiyi @typhoonzero, please review this PR, thanks.

typhoonzero
typhoonzero reviewed Mar 19, 2020
View reviewed changes
Copy link
Copy Markdown

@typhoonzero typhoonzero left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try not to use egg since the Python files will not be extracted. Use python setup.py bdist_wheel to build whl packages. This still need this setup.py file.

@Yancey0623
Copy link
Copy Markdown
Collaborator Author

Yancey0623 commented Mar 19, 2020

Try not to use egg since the Python files will not be extracted. Use python setup.py bdist_wheel to build whl packages. This still need this setup.py file.

Update the PR description.

@Yancey0623 Yancey0623 changed the title setup fluid as egg Package Fluid distribution achieve Mar 19, 2020
@Yancey0623 Yancey0623 merged commit b37df3c into sql-machine-learning:develop Mar 19, 2020
@Yancey0623 Yancey0623 deleted the setup_egg branch March 19, 2020 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@typhoonzero typhoonzero typhoonzero left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Yancey0623 @typhoonzero