Support explaining DNNs using SHAP#1694
Merged
shendiaomo merged 6 commits intosql-machine-learning:developfrom Jan 14, 2020
Merged
Support explaining DNNs using SHAP#1694shendiaomo merged 6 commits intosql-machine-learning:developfrom
shendiaomo merged 6 commits intosql-machine-learning:developfrom
Conversation
shendiaomo
requested review from
Yancey0623,
llxxxll,
tonyyang-svail,
typhoonzero,
wangkuiyi and
weiguoz
shendiaomo
force-pushed
the
explain_dnn
branch
from
2215132 to
0604594
Compare
wangkuiyi
previously approved these changes
Jan 13, 2020
shendiaomo
force-pushed
the
explain_dnn
branch
from
0604594 to
18c3fa6
Compare
wangkuiyi
previously approved these changes
Jan 14, 2020
Collaborator
|
Hi @shendiaomo, thanks for submitting this PR. Could you please add SQLs in the demo as our test cases? |
Collaborator
|
Maybe also test case like |
wangkuiyi
previously approved these changes
Jan 14, 2020
shendiaomo
force-pushed
the
explain_dnn
branch
from
054da66 to
c589de2
Compare
Collaborator
Author
Done. |
Collaborator
Author
Later in another PR? |
wangkuiyi
approved these changes
Jan 14, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is based on the discussion in shap/shap#280
The screenshot looks like: