Skip to content

Conversation

@wangkuiyi
Copy link
Collaborator

@wangkuiyi wangkuiyi commented May 15, 2020

Fix #2259
Fix #2257
Fix #2265

@wangkuiyi wangkuiyi requested a review from lhw362950217 May 15, 2020 18:56
@wangkuiyi
Copy link
Collaborator Author

A side effect of this PR is qiniu/qshell#264

@wangkuiyi wangkuiyi changed the title WIP Debug deploy in CI Deploy SQLFlow client in CI May 15, 2020
@wangkuiyi
Copy link
Collaborator Author

@lhw362950217 I debugged the deployment of sqlflow client in CI and verified it passed the test as reported here https://github.com/sql-machine-learning/sqlflow/runs/679517721 Then, I moved the deploy jobs back to the second stage "deploy".

@wangkuiyi wangkuiyi requested a review from tonyyang-svail May 15, 2020 21:57
Copy link
Collaborator

@tonyyang-svail tonyyang-svail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wangkuiyi wangkuiyi merged commit ce4a589 into develop May 15, 2020
@wangkuiyi wangkuiyi deleted the deploy_client branch May 15, 2020 22:04
lhw362950217 pushed a commit to lhw362950217/sqlflow that referenced this pull request Jun 18, 2020
* Do deploy at the first CI stage

* Enable deploy from pull request for debug

* make axel print

* axel print version

* Use Ubuntu Bionic for deploy Linux

* use the correct qshell filename

* Try using 0 instead of syscall.Stdin with terminal.IsTerminal

* Remove import syscall

* GOBIN=$PWD otherwise Windows cnanot access the output

* Use --overwrite with qshell rput

* Use $F instead of qshell because for windows it is qshell.exe

* Shorter lines

* brew install > /dev/null

* Upload sqlflow.exe for Windows

* Silence deploy

* move deploy to the second CI stage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

sqlflow client doesn't build for Windows Travis CI Linux VM axel downloads error Windows doesn't have sudo

3 participants