-
Notifications
You must be signed in to change notification settings - Fork 705
Deploy SQLFlow client in CI #2264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
A side effect of this PR is qiniu/qshell#264 |
|
@lhw362950217 I debugged the deployment of sqlflow client in CI and verified it passed the test as reported here https://github.com/sql-machine-learning/sqlflow/runs/679517721 Then, I moved the deploy jobs back to the second stage "deploy". |
tonyyang-svail
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Do deploy at the first CI stage * Enable deploy from pull request for debug * make axel print * axel print version * Use Ubuntu Bionic for deploy Linux * use the correct qshell filename * Try using 0 instead of syscall.Stdin with terminal.IsTerminal * Remove import syscall * GOBIN=$PWD otherwise Windows cnanot access the output * Use --overwrite with qshell rput * Use $F instead of qshell because for windows it is qshell.exe * Shorter lines * brew install > /dev/null * Upload sqlflow.exe for Windows * Silence deploy * move deploy to the second CI stage
Fix #2259
Fix #2257
Fix #2265