Skip to content

Polish keras wrapped model init with feature columns#2487

Merged
sneaxiy merged 4 commits intosql-machine-learning:developfrom
typhoonzero:polish_keras_wrap_model_init
Jun 18, 2020
Merged

Polish keras wrapped model init with feature columns#2487
sneaxiy merged 4 commits intosql-machine-learning:developfrom
typhoonzero:polish_keras_wrap_model_init

Conversation

@typhoonzero
Copy link
Copy Markdown
Collaborator

Polish keras wrapped model init with feature columns and fix running with Python 2 (Python 2 do not support inspect.signature)

@typhoonzero typhoonzero requested a review from sneaxiy June 18, 2020 08:59
Comment thread python/sqlflow_submitter/tensorflow/diag.py
Comment thread python/sqlflow_submitter/tensorflow/keras_with_feature_column_input.py Outdated
Copy link
Copy Markdown
Collaborator

@sneaxiy sneaxiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@sneaxiy sneaxiy merged commit befcd74 into sql-machine-learning:develop Jun 18, 2020
@typhoonzero typhoonzero deleted the polish_keras_wrap_model_init branch June 18, 2020 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants