Skip to content

Unify local and PAI submitter#2841

Merged
sneaxiy merged 10 commits intosql-machine-learning:developfrom
typhoonzero:unify_local_and_pai_submitter
Aug 19, 2020
Merged

Unify local and PAI submitter#2841
sneaxiy merged 10 commits intosql-machine-learning:developfrom
typhoonzero:unify_local_and_pai_submitter

Conversation

@typhoonzero
Copy link
Copy Markdown
Collaborator

No description provided.

@typhoonzero typhoonzero requested a review from sneaxiy August 19, 2020 00:46
disk_cache="{{.DiskCache}}"=="true",
batch_size={{.BatchSize}},
epoch={{.Epoch}})
os.chdir(temp_dir)
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can remove os.chdir(temp_dir) here.

Copy link
Copy Markdown
Collaborator

@sneaxiy sneaxiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@sneaxiy sneaxiy merged commit e48074d into sql-machine-learning:develop Aug 19, 2020
@typhoonzero typhoonzero deleted the unify_local_and_pai_submitter branch August 19, 2020 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants