Fix PAI XGBoost model evaluation driver bug#2864
Merged
typhoonzero merged 1 commit intosql-machine-learning:developfrom Aug 22, 2020
Merged
Fix PAI XGBoost model evaluation driver bug#2864typhoonzero merged 1 commit intosql-machine-learning:developfrom
typhoonzero merged 1 commit intosql-machine-learning:developfrom
Conversation
Collaborator
|
I think it's better to change to： from runtime.dbapi import PaiioConnection
conn = PaiioConnection.from_table(result_table)and keep other place as they are |
sneaxiy
force-pushed
the
fix_driver_bug
branch
from
7a590d2 to
05397e9
Compare
Collaborator
Author
|
@lhw362950217 Great idea! I have changed the implementation as you suggested. Please take a look. |
typhoonzero
approved these changes
Aug 22, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.